Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional gherkin scenarios for the options.ini file #9130

Merged

Conversation

pcenov
Copy link
Member

@pcenov pcenov commented Feb 21, 2022

No description provided.

@pcenov
Copy link
Member Author

pcenov commented Feb 21, 2022

@radinamatic

And I save my changes
And I run the "kolibri start" command in the terminal or command prompt
And I go to Device>Channels
And I go to *Device>Channels*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually separate this so, Device > Channels, right?

When I add "ENABLE_CUSTOM_CHANNEL_NAV = True" under the [Learn] section
And I save my changes
And I run the "kolibri start" command in the terminal or command prompt
And I go to *Device>Channels*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem for separation here.

@radinamatic
Copy link
Member

Looking good so far, thank you! Let me now if there's still something pending, otherwise I'll go ahead and merge 👍🏽

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have these checked and updated, thank you! 👍🏽 💯

@radinamatic radinamatic merged commit 74afa48 into learningequality:release-v0.15.x Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants